Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor.mod: put github.com/pkg/browser in the right group #5407

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

thaJeztah
Copy link
Member

commit fcfdd7b (#5344) introduced github.com/pkg/browser as a direct dependency, but it ended up in the group for indirect dependencies.

commit fcfdd7b introduced github.com/pkg/browser
as a direct dependency, but it ended up in the group for indirect dependencies.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah added this to the 28.0.0 milestone Sep 5, 2024
@thaJeztah thaJeztah self-assigned this Sep 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.73%. Comparing base (f75abad) to head (1b8180a).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5407   +/-   ##
=======================================
  Coverage   59.73%   59.73%           
=======================================
  Files         345      345           
  Lines       23394    23394           
=======================================
  Hits        13974    13974           
  Misses       8450     8450           
  Partials      970      970           

@laurazard
Copy link
Member

No idea how it ended up there 🙈

@laurazard laurazard merged commit 2b6d2d9 into docker:master Sep 5, 2024
110 checks passed
@thaJeztah thaJeztah deleted the mod_tidy branch September 5, 2024 12:48
@thaJeztah
Copy link
Member Author

Yeah, go mod is really bad at this; I still need to look if there's a linter for this, or if they can just fix this somehow because it happens all the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants