Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add docsRepoType in environmentController #75

Merged
merged 9 commits into from
Mar 2, 2020
Merged

add docsRepoType in environmentController #75

merged 9 commits into from
Mar 2, 2020

Conversation

mingwli
Copy link
Contributor

@mingwli mingwli commented Feb 27, 2020 •
edited
Loading

@codecov-io
Copy link

codecov-io commented Feb 27, 2020 •
edited
Loading

Codecov Report

Merging #75 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
+ Coverage   87.75%   87.84%   +0.08%     
==========================================
  Files          24       24              
  Lines         727      732       +5     
  Branches       56       57       +1     
==========================================
+ Hits          638      643       +5     
  Misses         77       77              
  Partials       12       12
Flag Coverage Δ
#unit 87.84% <100%> (+0.08%) ⬆️
Impacted Files Coverage Δ
src/credential/credentialController.ts 93.24% <ø> (ø) ⬆️
src/shared.ts 90% <ø> (ø) ⬆️
src/observers/telemetryObserver.ts 97.56% <100%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71319dd...cb43824. Read the comment docs.

@mingwli mingwli mentioned this pull request Feb 28, 2020
Merged
928PJY
928PJY reviewed Feb 28, 2020
View reviewed changes
src/common/loggingEvents.ts Outdated Show resolved Hide resolved
928PJY
928PJY approved these changes Mar 2, 2020
View reviewed changes
Copy link
Collaborator

@928PJY 928PJY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mingwli mingwli merged commit 16a8858 into docascode:master Mar 2, 2020
@mingwli mingwli deleted the env-docs-repo-type branch March 4, 2020 06:38
928PJY pushed a commit that referenced this pull request Aug 24, 2020
@mingwli
add docsRepoType in environmentController (#75)
90aa057 
* add docsRepoType in environmentController
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@928PJY 928PJY 928PJY approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mingwli @codecov-io @928PJY