Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

19 remove orphaned cov argument from normallhs sampling #20

Merged

Conversation

ClaasRostock
Copy link
Collaborator

  • removed orphaned _cov argument from normalLhs sampling
  • updated to dictIO>=0.3.0 (from dictIO>=0.2.9)

@ClaasRostock ClaasRostock linked an issue Jan 8, 2024 that may be closed by this pull request
@ClaasRostock ClaasRostock self-assigned this Jan 8, 2024
@frl000
Copy link
Member

frl000 commented Jan 9, 2024

Ah, good point. I forgot that. It is okay for me If we drop that cov argument. If there is one day a need to get it back, we will find.
The basic idea was besides scaling and stretching also to apply rotation by simple sampling setup. Otherwise one can achieve that with latter matrix ops as well.
The reason why I did not implement that from the beginning was the limitation of
scipy.stats.norm(loc=mean, scale=std).ppf(distribution),
only taking (nx1) vectors for mean and scale. Rotation would require a (nxn) matrix.
I write this here as a reminder...

@ClaasRostock ClaasRostock merged commit 5735678 into main Jan 9, 2024
11 checks passed
@ClaasRostock ClaasRostock deleted the 19-remove-orphaned-_cov-argument-from-normallhs-sampling branch January 9, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove orphaned _cov argument from normalLhs sampling
2 participants