Skip to content

Commit

Permalink
removed orphaned _cov argument from normalLhs sampling
Browse files Browse the repository at this point in the history
  • Loading branch information
ClaasRostock committed Jan 8, 2024
1 parent 2614b20 commit 81e3df6
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 7 deletions.
9 changes: 3 additions & 6 deletions src/farn/sampling/sampling.py
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ def _set_up_known_sampling_types(self):
],
"optional_args": [
"_ranges",
"_cov",
],
},
"sobol": {
Expand Down Expand Up @@ -283,15 +282,13 @@ def _generate_samples_using_uniform_lhs_sampling(self) -> Dict[str, List[Any]]:
return samples

def _generate_samples_using_normal_lhs_sampling(self) -> Dict[str, List[Any]]:
"""LHS using gaussian normal distributions
"""LHS using gaussian normal distributions.
required input arguments:
* _names: required names template
* _numberOfSamples: required how many samples
* _mu: required absolute location vector of distribution center point (origin)
* _sigma: variation (vector), or required scalar, optional vector, optional cov
or
NOT IMPLEMENTED, DOES NOT MAKE MUCH SENSE!
* _cov: @ _mu optional rotation (tensor), otherwise I(_numberOfSamples,_numberOfSamples).
* _sigma: variation (vector), or required scalar, optional vector
"""
_ = self._check_length_matches_number_of_names("_mu")
if isinstance(self.sampling_parameters["_sigma"], Sequence):
Expand Down
2 changes: 1 addition & 1 deletion tests/test_dicts/test_farnDict_normalLhs
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ test normalLhs
for sample set dimensioning
purpose:
generate a spacial, normal distributed sample set
_ranges: do not dimension the spacial extent of lhs, only limiting. for dimensioning _sigma (_cov) is used
_ranges: do not dimension the spatial extent of lhs, only limiting. For dimensioning, _sigma is used.
*/
_layers {
lhsvar
Expand Down

0 comments on commit 81e3df6

Please sign in to comment.