Merge pull request #47 from dmdhrumilmistry/fix-nuitka-onefile-error

Fix nuitka not found error on ubuntu

README.md

@@ -170,6 +170,14 @@ The disclaimer advises users to use the open source project for ethical and legi
 - [View How to create a Trojan](./HowTo/Malwares/CreateTrojanPackage.md)
 - [Generator Script](./examples/EvilFiles/generatorScript.py)
 
+`Note`: On linux host machines, user needs to install `patchelf` package. Install using below command.
+
+```bash
+apt/dnf/yum install patchelf
+```
+
+> Above command needs root privileges.
+
 ## Have any Ideas 💡 or issue
 
 - Create an issue

pyhtools/evil_files/exec_generator.py

@@ -2,9 +2,9 @@
 module: generator.py
 description: generates evil file executable
 '''
+from enum import Enum
 from subprocess import call
 from os import name as os_name
-from enum import Enum
 
 
 class Compilers(Enum):
@@ -15,7 +15,7 @@ class Compilers(Enum):
 
 class ExecutableGenerator:
     '''
-    creates executable
+    creates executable from python script.
     '''
 
     def __init__(self, file_path: str, output_dir: str = None, icon: str = None, compiler: Compilers = Compilers.DEFAULT, onefile: bool = True, remove_output: bool = True,) -> None:
@@ -26,7 +26,6 @@ def __init__(self, file_path: str, output_dir: str = None, icon: str = None, com
         self.__options = {
             'onefile': onefile,
             'standalone': True,
-            'onefile': True,
             'remove-output': remove_output,
             'output-dir': output_dir,
         }
@@ -44,7 +43,14 @@ def __init__(self, file_path: str, output_dir: str = None, icon: str = None, com
             self.__options['mingw'] = True
 
     def __generate_command(self):
-        command = 'nuitka '
+        '''
+        generates nuitka command
+        '''
+        if os_name == 'nt':
+            command = 'python -m nuitka '
+        else:
+            command = 'python3 -m nuitka '
+
         for key in self.__options:
             cmd = ''
             value = self.__options[key]
@@ -64,5 +70,9 @@ def __generate_command(self):
         return command
 
     def generate_executable(self):
+        # linux devices requires patchelf to be installed
+        # sudo apt install patchelf 
         command = self.__generate_command()
-        return call(command.split(), shell=True)
+
+        # vuln: os command injection
+        return call(command, shell=True)

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "pyhtools"
-version = "2.2.0"
+version = "2.2.1"
 description = "Python Hacking Tools (PyHTools) (pht) is a collection of python written hacking tools consisting of network scanner, arp spoofer and detector, dns spoofer, code injector, packet sniffer, network jammer, email sender, downloader, wireless password harvester credential harvester, keylogger, download&execute, and reverse_backdoor along with website login bruteforce, scraper, web spider etc. PHT also includes malwares which are undetectable by the antiviruses."
 authors = ["Dhrumil Mistry <[email protected]>"]
 license = "MIT"