Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup commented code, golangci-lint fixes #70

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

angaz
Copy link

@angaz angaz commented Oct 5, 2022

Cleaned up some commented out code, and ran golangci-lint, and fixed the errors.

I also thought that generate function had a bit too many parameters, so I made a struct for the params for that function.

@codecov-commenter
Copy link

Codecov Report

Merging #70 (ded6a10) into master (71d3edd) will decrease coverage by 0.20%.
The diff coverage is 62.22%.

@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
- Coverage   66.23%   66.02%   -0.21%     
==========================================
  Files           4        4              
  Lines         465      471       +6     
==========================================
+ Hits          308      311       +3     
- Misses        146      149       +3     
  Partials       11       11              
Impacted Files Coverage Δ
stringer.go 60.88% <62.22%> (-0.17%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Owner

@dmarkham dmarkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for sure better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants