Additional sensor attributes with device information, diagnostics sensors #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additional device attributes on sensors
Add additional product details
Add additional product details as attributes, attribute constants, classify diagnostics sensors and disable sensors
|
@dm82m Hi Dirk - on xmas holidays now. Let me know if you want to pursue this further, happy to provide further PR if you interested. Wishing nice holidays, thanks Martin |
|
@dm82m please let me know if you want to merge this PR or not. I did this based on your own suggestions, but never heard back. thanks, Martin |
|
Sorry I forgot about this PR. Will have a look the next days. |
|
Hi Dirk, did you manage to have a look into this? Thanks Martin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in this issue, have implemented point 4 and 8.
Let me know if you want optional configuratoin flags for diagnostics/disable sensors.
Thanks
M