This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 424
[WIP] [DONT MERGE] Enable demangling of C++ symbols in the stacktrace #3003
Draft
ErnyTech
wants to merge
2
commits into
dlang:master
Choose a base branch
from
ErnyTech:cppstack
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
Added experimental `C++` symbol demanling in the stacktrace | ||
|
||
This feature is availableby passing the following switches to your executable (not to the compiler): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ideally, the release note should start by describing the feature itself. You've been working on it for quite some time, so you know exactly what it entails, but not everyone does. Something like:
Note that this is just an example, but it illustrate a few points:
|
||
- `--DRT-cpptrace=enable:y`: Enable demangling of C++ symbols | ||
- `--DRT-cpptrace=prefix:<your_prefix>`: Change the prefix preceding the demangled C++ name (by default would be `[C++]`) | ||
- `--DRT-cpptrace=noprefix:n`: Disable adding the prefix to C ++ demangle names | ||
|
||
To use this function in the Posix platform you will need to link your executable to the phobos shared library, compile the program by passing -defaultlib=libphobos2.so to DMD. | ||
|
||
Example: | ||
|
||
``` | ||
module cpp_trace.d | ||
|
||
extern(C++) void f1() | ||
{ | ||
throw new Exception("exception"); | ||
} | ||
|
||
void main() | ||
{ | ||
try | ||
{ | ||
f1(); | ||
} | ||
catch (Exception e) | ||
{ | ||
import core.stdc.stdio; | ||
auto str = e.toString(); | ||
printf("%.*s\n", cast(int)str.length, str.ptr); | ||
} | ||
} | ||
``` | ||
|
||
If you run the executable with the following switches `./<executable> --DRT-cpptrace=enable:y`, you would get this output: | ||
|
||
``` | ||
object.Exception@cpp_trace.d(3): exception | ||
---------------- | ||
src/cpp_trace.d:5 [C++] f1() [ADDR] | ||
src/cpp_trace.d:12 _Dmain [ADDR] | ||
``` | ||
|
||
Instead, if you run the executable with the following switches `./<executable> --DRT-cpptrace=enable:y --DRT-cpptrace=prefix:CPP`, you would get this output: | ||
|
||
``` | ||
object.Exception@cpp_trace.d(5): exception | ||
---------------- | ||
src/cpp_trace.d:5 [CPP] f1() [ADDR] | ||
src/cpp_trace.d:12 _Dmain [ADDR] | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit more selling to the user (we tend to mark everything as "experimental" and that doesn't inspire confidence).
You can just note later that it is not enabled by default.