remove redundant brackets #16744
remove redundant brackets #16744
Conversation
|
Thanks for your pull request and interest in making D better, @0-v-0! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#16744" |
| @@ -2168,7 +2168,7 @@ void cdcom(ref CGstate cg, ref CodeBuilder cdb,elem *e,regm_t *pretregs) | |||
| } | |||
| tym_t tym = tybasic(e.Ety); | |||
| int sz = _tysize[tym]; | |||
| uint rex = (I64 && sz == 8) ? REX_W : 0; | |||
There was a problem hiding this comment.
this is not more easy to read as a result of this change
| @@ -172,7 +172,7 @@ bool expressionsToString(ref OutBuffer buf, Scope* sc, Expressions* exps) | |||
| // char literals exp `.toStringExp` return `null` but we cant override it | |||
| // because in most contexts we don't want the conversion to succeed. | |||
| IntegerExp ie = e4.isIntegerExp(); | |||
| const ty = (ie && ie.type) ? ie.type.ty : Terror; | |||
| @nogc: | ||
| nothrow: | ||
| pure: |
There was a problem hiding this comment.
please leave this as is
There was a problem hiding this comment.
This is not the kind of change that we accept, mainly because it does not bring a net benefit. This sort of change is quite subjective and it can be argued both ways so instead of entering in meaningless debates we go down the conservative route and flat out reject cosmetic changes to the code.
No description provided.