Use the async session.asave method if it exists #2092
+61
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support was added in django/django#17372 (slated for release in 5.1)
We can use this API if it exists, otherwise, we fallback to a
sync_to_async
bridge.This does break backwards compatibility, which I'm not terribly happy about but I'm not sure how best to fix it.
If users overrode
save_session
in a subclass they would expect that to still work, so I thought the best way to do this was to make it async in the base class and thenawait
it, so at least it will be obvious that it doesn't work (python will raise an exception aboutawait
ing a non-awaitable), but I'm open to other solutions.