Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update renderers.py #1153

Closed
wants to merge 1 commit into from
Closed

Update renderers.py #1153

wants to merge 1 commit into from

Conversation

Anirudh3167
Copy link

Solved the included array issue at
#1109

Fixes #
#1109

Description of the Change

The issue #1109 is solved

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

Solved the included array issue at
#1109
@sliverc
Copy link
Member

sliverc commented Jun 6, 2023

Thanks for working on this.

I have to say it might not be that clear from the issue, but the included array should only be included in the response if it is requested, meaning that the client has provided the include parameter. In your change, it will always be returned. The code needs to be adjusted likewise.

Also make sure that you add a test, add yourself to authors, add a changelog entry and make sure that the automatic checks pass.

@sliverc
Copy link
Member

sliverc commented Aug 26, 2023

As there has been no feedback, I assume you do not have time to continue working on this. Therefore, closing this PR. Feel free to ping me, in case you want to continue working on it as per comment above.

I have now clarified in the issue #1109 when included key needs to be added and when not, to avoid confusion.

@sliverc sliverc closed this Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants