-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adds a link to published content #272
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #272 +/- ##
=======================================
Coverage 86.60% 86.60%
=======================================
Files 23 23
Lines 799 799
Branches 105 105
=======================================
Hits 692 692
Misses 81 81
Partials 26 26 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The branch needs to be brought up to date.
Review contains a question and raises an issue with a duplicated template
@@ -8,10 +8,8 @@ skip_missing_interpreters=True | |||
|
|||
[testenv] | |||
deps = | |||
-r{toxinidir}/tests/requirements/requirements_base.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this because I thought that the isort and flake8 deps needed it, obviously not so no issues removing this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @marksweb ! I am not sure if all versionable objects need to have a get_absolute_url
method.
This adds an action button on the published content to take you to the content users will see via
get_absolute_url
.How it looks with page content;
How it looks with Alias where
get_absolute_url
returns the preview URL;