fix: Issue #641 created by typo in widgets.py #652
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issue #641.
I traced it back to a simple typo in
widgets.py
which left thecancel_plugin_url
property in the editor's setting empty (but filled the unused propertyclancel_plugin_url
).In effect, the cmspluings'
plugin.js
in turn creates a POST request with empty content to the edit endpoint (where the form was originally loaded), effectively deleting the text as opposed to the newly created plugins. The correct behavior would call thecancel_plugin_url
endpoint which in turn deletes any added child plugins when cancel is pressed.References