Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s3 Compatible: registry s3 driver support radosgw #959

Closed
wants to merge 2 commits into from
Closed

s3 Compatible: registry s3 driver support radosgw #959

wants to merge 2 commits into from

Conversation

simpleshuai
Copy link

Now, registry s3 driver unsupport RadosGW.
The pull request #808 @lorieri aims to this issue. Regrettably, pull request #808 is not enough beacuse there are several amazon S3 REST API that registry used but RadosGW unsupport:

This pull request aims to fix S3 compatibility mentioned above, and this PR work with two PRs below

About test, if there is a RadosGW , set env below to run CI tests using RadosGW as storage

AWS_REGION=generic
AWS_ACCESS_KEY=xxxxx
AWS_SECRET_KEY=xxxxx
S3_BUCKET=xxxx
S3_ENTRYPOINT=xxxx

In my environment, I set env mentioned above using a RadosGW as storage , all the tests in registry/storage/driver/testsuites/testsuites.go passed

Signed-off-by: wangmingshuai [email protected]

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "master" [email protected]:wangmingshuai/distribution.git somewhere
$ cd somewhere
$ git rebase -i HEAD~2
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

@PotHix
Copy link

PotHix commented Apr 20, 2016

All PRs related to radosgw were closed but I could not understand why.
Is it working now or this feature was abandoned?

thaJeztah pushed a commit to thaJeztah/distribution that referenced this pull request Apr 22, 2021
* re-compress jpg images losslessly using jpegoptim

* re-compress png images losslessly using zopflipng
thaJeztah pushed a commit to thaJeztah/distribution that referenced this pull request Jan 19, 2022
* re-compress jpg images losslessly using jpegoptim

* re-compress png images losslessly using zopflipng
dylanrhysscott pushed a commit to digitalocean/docker-distribution that referenced this pull request Jan 5, 2023
* re-compress jpg images losslessly using jpegoptim

* re-compress png images losslessly using zopflipng
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants