Check that host key exists before using in dsq_filter_rest_url #106
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In environments where the
$rest_url
does not contain a host, like when running PHP scripts on the command line via Supervisord, php warns with a notice. To prevent these notices, this PR adds a check for the existence of 'host' before trying to use it in thedsq_filter_rest_url
function.Motivation and Context
Fixes issue #57, discussed more in #60.
How Has This Been Tested?
docker exec -it disqus-wordpress-plugin_wordpress_1 /bin/bash
my-script.php
with the followingwp-config.php
to remove the host:Undefined index: HTTP_HOST" for no web server
withdocker exec -it disqus-wordpress-plugin_wordpress_1 /bin/bash wp eval-file my-script.php
Types of changes
Checklist: