Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version bump #53

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Version bump #53

merged 1 commit into from
Aug 8, 2023

Conversation

SamSaffron
Copy link
Member

No description provided.

@SamSaffron SamSaffron merged commit 165e7f0 into main Aug 8, 2023
11 checks passed
@SamSaffron SamSaffron deleted the bump branch August 8, 2023 05:08
@casperisfine
Copy link

I don't know if you are aware but neither 1.1.3 nor 1.1.4 were pushed to rubygems: https://rubygems.org/gems/mini_mime

@SamSaffron
Copy link
Member Author

yikes I was just about to push it @casperisfine but it looks like tests are failing on main...

@casperisfine
Copy link

👀

@casperisfine
Copy link

I can repro after updating mime-types.

@casperisfine
Copy link

  1) Failure:
MiniMimeTest#test_full_parity_with_mime_types [/Users/byroot/src/github.com/casperisfine/mini_mime/test/mini_mime_test.rb:139]:
Expected ".ggs" to return "application/vnd.geogebra.slides", got: nil
Expected ".cjs" to return "text/javascript", got: nil

@casperisfine
Copy link

Caused by mime-types/mime-types-data@0278657

Not sure what is best here, I can easily ignore these in the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants