Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Add breadcrumbs to LLMs and Persona admin pages #666

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

martin-brennan
Copy link
Contributor

Followup to #656,
adding these back in with the new core component.

Followup to #656,
adding these back in with the new core component.
Copy link
Contributor

@tgxworld tgxworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me. I do wonder if we should write system tests to ensure the way this plugin uses a core component is correct.

@martin-brennan
Copy link
Contributor Author

Noting that I am writing system specs for this, won't merge until I do. Ran into some breadcrumbs issues in core that cvx is fixing.

@SamSaffron
Copy link
Member

oh @martin-brennan this needs a rebase (to allow for new screen)

@martin-brennan
Copy link
Contributor Author

@SamSaffron yep all good, I am having some struggles with the breadcrumb component ATM, and I am writing system specs for this too, will put this back in Draft for now.

@martin-brennan martin-brennan marked this pull request as draft July 3, 2024 00:11
@martin-brennan martin-brennan marked this pull request as ready for review July 9, 2024 06:23
@martin-brennan martin-brennan merged commit da6d70d into main Jul 10, 2024
5 checks passed
@martin-brennan martin-brennan deleted the feature/add-breadcrumbs-v2 branch July 10, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants