Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TV Data Fetching - Refactor #146

Merged
merged 12 commits into from
Mar 27, 2024
Merged

TV Data Fetching - Refactor #146

merged 12 commits into from
Mar 27, 2024

Conversation

bryantgillespie
Copy link
Contributor

@bryantgillespie bryantgillespie commented Mar 21, 2024

This PR is a refactor / cleanup of data fetching logic for TV pages to be inline with rest of website.

This is an intermediate step until we merge the two instances into one.

  • Use Nuxt useAsyncData calls
  • Add separate plugin for TV
  • Extract util for shared date transform

Ground work for this PR #148 - for content updates

@bryantgillespie bryantgillespie changed the base branch from tv-me to main March 21, 2024 15:29
Copy link

netlify bot commented Mar 26, 2024

Deploy Preview for directus-website ready!

Name Link
🔨 Latest commit 2e9a27c
🔍 Latest deploy log https://app.netlify.com/sites/directus-website/deploys/6604096c6a6f160008739c6a
😎 Deploy Preview https://deploy-preview-146--directus-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bryantgillespie bryantgillespie marked this pull request as ready for review March 26, 2024 19:40
Copy link
Member

@paescuj paescuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, besides a small key conflict 🚀

(Already approving but the conflict should be resolved before merging)

pages/tv/all.vue Outdated Show resolved Hide resolved
pages/tv/index.vue Outdated Show resolved Hide resolved
bryantgillespie and others added 2 commits March 27, 2024 07:56
Co-authored-by: Pascal Jufer <[email protected]>
Co-authored-by: Pascal Jufer <[email protected]>
@bryantgillespie bryantgillespie merged commit be9caa8 into main Mar 27, 2024
6 checks passed
@bryantgillespie bryantgillespie deleted the tv-me-data-fetching branch March 27, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants