Skip to content

Commit

Permalink
Attempt to fix prod cascade
Browse files Browse the repository at this point in the history
  • Loading branch information
rijkvanzanten committed Jul 27, 2023
1 parent a56ac14 commit 3d1d060
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 12 deletions.
6 changes: 3 additions & 3 deletions components/Base/Container.vue
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,13 @@ withDefaults(defineProps<BaseContainerProps>(), {
</script>

<template>
<component :is="tag" class="container">
<component :is="tag" class="base-container">
<slot />
</component>
</template>

<style scoped lang="scss">
.container {
.base-container {
display: grid;
grid-template-columns:
[full-start] minmax(var(--space-5), 1fr)
Expand All @@ -38,7 +38,7 @@ withDefaults(defineProps<BaseContainerProps>(), {
}
}
.container :deep(> *) {
.base-container :deep(> *) {
/** acts as an overridable default */
grid-column: standard;
}
Expand Down
3 changes: 2 additions & 1 deletion components/Nav/Banner.vue
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,11 @@ const dismiss = (id: string) => {
</template>
<style scoped lang="scss">
.banner-container {
.base-container.banner-container {
background: linear-gradient(88deg, var(--purple-300) 0%, var(--pink-200) 100%);
padding-block: var(--space-1);
cursor: pointer;
grid-column: full;
}
.banner {
Expand Down
12 changes: 4 additions & 8 deletions components/Nav/Header.vue
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ const { data: menu } = useAsyncData('header-nav', () =>
const headerContainer = ref();
const navActive = ref(false);
const navActiveSection = ref<string | null>('62c04c6c-5793-4702-8ed1-73dd563fd605');
const navActiveSection = ref<string | null>(null);
const toggleActiveSection = (id: string) => {
if (unref(navActiveSection) === id) {
Expand Down Expand Up @@ -59,7 +59,7 @@ onClickOutside(headerContainer, resetNavState);
<template>
<BaseContainer ref="headerContainer" class="header-container">
<ClientOnly>
<NavBanner class="banner-bar" />
<NavBanner />
</ClientOnly>

<header class="header">
Expand Down Expand Up @@ -132,7 +132,7 @@ a {
}
}
.header-container {
.base-container.header-container {
position: fixed;
top: 0;
z-index: 5;
Expand All @@ -143,10 +143,6 @@ a {
width: 100%;
}
.banner-bar {
grid-column: full;
}
.header {
display: flex;
flex-wrap: wrap;
Expand Down Expand Up @@ -223,7 +219,7 @@ a {
}
@media (width > 75rem) {
.header-container {
.base-container.header-container {
position: sticky;
top: 0;
overflow: visible;
Expand Down

0 comments on commit 3d1d060

Please sign in to comment.