Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fixes #1

wants to merge 5 commits into from

Conversation

actualmermaid
Copy link

No description provided.

dimitrovvlado
dimitrovvlado reviewed Oct 10, 2018
View reviewed changes
Copy link
Owner

@dimitrovvlado dimitrovvlado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, please see my comment on the config.go

cmd/config.go
@@ -60,10 +60,6 @@ func (i *configCmd) run() error {
return err
}

if err := ioutil.WriteFile(i.home.ConfigFile(), j, 0755); err != nil {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this line will prevent the config command from storing the configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimitrovvlado dimitrovvlado dimitrovvlado left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@actualmermaid @dimitrovvlado