Use copy with binary.

dimitri · Jul 31, 2024 · 3cd2c07 · 3cd2c07
1 parent 792c554
commit 3cd2c07
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/bin/pgcopydb/pgsql.c b/src/bin/pgcopydb/pgsql.c
@@ -2929,7 +2929,7 @@ pg_copy_from_stdin(PGSQL *pgsql, const char *qname)
 {
 	char sql[BUFSIZE] = { 0 };
 
-	sformat(sql, sizeof(sql), "COPY %s FROM stdin", qname);
+	sformat(sql, sizeof(sql), "COPY %s FROM stdin WITH (format binary)", qname);
 
 	char *endpoint =
 		pgsql->connectionType == PGSQL_CONN_SOURCE ? "SOURCE" : "TARGET";
@@ -3073,7 +3073,7 @@ pg_copy_send_query(PGSQL *pgsql, CopyArgs *args, ExecStatusType status)
 							  args->srcAttrList,
 							  args->srcQname);
 		}
-		appendPQExpBuffer(sql, "to stdout");
+		appendPQExpBuffer(sql, "to stdout with (format binary);");
 	}
 	else if (status == PGRES_COPY_IN)
 	{
@@ -3090,7 +3090,7 @@ pg_copy_send_query(PGSQL *pgsql, CopyArgs *args, ExecStatusType status)
 
 		if (args->freeze)
 		{
-			appendPQExpBuffer(sql, " with (freeze)");
+			appendPQExpBuffer(sql, " with (freeze, format binary)");
 		}
 	}
 	else

diff --git a/src/bin/pgcopydb/table-data.c b/src/bin/pgcopydb/table-data.c
@@ -1440,6 +1440,8 @@ copydb_prepare_copy_query(CopyTableDataSpec *tableSpecs, CopyArgs *args)
 			}
 		}
 
+		appendPQExpBuffer(srcWhereClause, " WITH (FORMAT BINARY)");
+
 		if (PQExpBufferBroken(srcWhereClause))
 		{
 			log_error("Failed to create where clause for %s: out of memory",
@@ -1474,6 +1476,8 @@ copydb_prepare_summary_command(CopyTableDataSpec *tableSpecs)
 		appendPQExpBuffer(command, " %s", tableSpecs->copyArgs.srcWhereClause);
 	}
 
+	appendPQExpBuffer(command, "WITH (FORMAT BINARY)");
+
 	tableSummary->command =
 		command->data != NULL ? strdup(command->data) : NULL;