Remove remaining non-wired RestTemplate constructors #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the last places where a RestTemplate was constructed from scratch rather than being autowired for the same reasons outlined in #754 and adds tests whenever practical.
Also refactors out the classes using those RestTemplates into explicit components, rather than Context injected beans, since there's no reason to have Context injected beans without any polymorphism.
Note: These changes affect a set of services which are a a bit less straightforward to test (case claim and "FormattedQuestionsService" (I think that's "Beautiful forms"?) and I haven't quite touched all of those paths yet to confirm that the Context Bean -> Component change is indeed a no-op