Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to Ubuntu 18.04 and installation of Python 3.10 #6260

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gherceg
Copy link
Contributor

@gherceg gherceg commented Apr 12, 2024

This is long overdue, but we don't have any control machines running 18.04 and self hosters shouldn't either, so we should cleanup our relevant scripts to only handle 22.04.

I also noticed the test container Daniel added was using 18.04, and updated that, but admittedly don't have context on that change. @millerdev if that is outside of the scope of this PR let me know and I can remove it.

Before merging:

  • test this (maybe use vagrant locally, or a new machine on staging since we have other control setup issues to test)
  • is there anything to announce? We already said we wouldn't support 18.04 as of July 1st, 2023, so I think no announcement is needed.
Environments Affected

None

Announce New Release
  • After merging, I will follow these instructions
    to announce a new commcare-cloud release.

gherceg added 2 commits April 12, 2024 10:37
The system version of python was 3.6 on 18.04, and is 3.10 on 22.04. Now
that we have fully transitioned to 22.04 (for control machines at
least), we can safely remove the code related to installing and setting
up 3.10 virtual environments on 18.04.
Copy link
Contributor

@millerdev millerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think no announcement is needed.

I think I agree, although what would happen if someone was still running 18.04? Will their control machine still work? If yes not, should we add a check for that and print an error about unmet requirements?

@@ -117,10 +117,7 @@ If you get to this point, congratulations! ``commcare-cloud`` is installed.
Manual Installation
-------------------

You will need python 3.10 installed to follow these instructions. See
:ref:`installation/2-manual-install:Upgrade to Python 3.10` for instructions on
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did the target of this link get removed earlier? I could not find it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I think it was removed here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants