Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only store errors results #74

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

mkangia
Copy link
Contributor

@mkangia mkangia commented Nov 7, 2024

https://dimagi.atlassian.net/browse/SC-4021

Minor change to skip storing results for the task "process_dataset_change" if its succeeded.

Settings can be found here

  1. https://docs.celeryq.dev/en/stable/userguide/configuration.html#task-ignore-result
  2. https://docs.celeryq.dev/en/stable/userguide/configuration.html#task-store-errors-even-if-ignored

the naming is without the "task-" when passed through the decorator.

@mkangia
Copy link
Contributor Author

mkangia commented Nov 7, 2024

Tested on staging,

sending a new request for change, does not increase the number of keys in redis and task was executed successfully as seen in celery logs

@mkangia mkangia merged commit f97eb92 into master Nov 7, 2024
3 checks passed
@mkangia mkangia deleted the mk/4021-skip-storing-successful-results branch November 7, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants