Merge pull request #72 from dimagi/mk/3475-expire-user-permissions

Expire user permissions

hq_superset/api.py

@@ -11,9 +11,9 @@
     json_success,
 )
 
-from .models import DataSetChange
-from .oauth2_server import authorization, require_oauth
-from .tasks import process_dataset_change
+from hq_superset.models import DataSetChange
+from hq_superset.oauth2_server import authorization, require_oauth
+from hq_superset.tasks import process_dataset_change
 
 
 class OAuth(BaseApi):

hq_superset/const.py

@@ -48,3 +48,8 @@
     "Datasets": [MENU_ACCESS_PERMISSION],
     "ExploreFormDataRestApi": [CAN_READ_PERMISSION]
 }
+
+DOMAIN_PREFIX = "hqdomain_"
+SESSION_USER_DOMAINS_KEY = "user_hq_domains"
+SESSION_OAUTH_RESPONSE_KEY = "oauth_response"
+SESSION_DOMAIN_ROLE_LAST_SYNCED_AT = "domain_role_last_synced_at"

hq_superset/hq_domain.py

@@ -1,10 +1,31 @@
-from flask import flash, g, redirect, request, session, url_for
+from datetime import timedelta
 
-from .utils import SESSION_USER_DOMAINS_KEY
+import superset
+from flask import current_app, flash, g, redirect, request, session, url_for
+from superset.config import USER_DOMAIN_ROLE_EXPIRY
+from superset.extensions import cache_manager
+
+from hq_superset.const import (
+    SESSION_DOMAIN_ROLE_LAST_SYNCED_AT,
+    SESSION_USER_DOMAINS_KEY,
+)
+from hq_superset.utils import DomainSyncUtil, datetime_utcnow
 
 
 def before_request_hook():
-    return ensure_domain_selected()
+    """
+    Call all hooks functions set in sequence and
+    if any hook returns a response,
+    break the chain and return that response
+    """
+    hooks = [
+        ensure_domain_selected,
+        sync_user_domain_role
+    ]
+    for _function in hooks:
+        response = _function()
+        if response:
+            return response
 
 
 def after_request_hook(response):
@@ -13,7 +34,7 @@ def after_request_hook(response):
         "AuthDBView.login",
         "AuthOAuthView.logout",
     ]
-    if (request.url_rule and request.url_rule.endpoint in logout_views):
+    if request.url_rule and (request.url_rule.endpoint in logout_views):
         response.set_cookie('hq_domain', '', expires=0)
     return response
 
@@ -24,6 +45,8 @@ def after_request_hook(response):
     'AuthOAuthView.login',
     'AuthOAuthView.logout',
     'AuthOAuthView.oauth_authorized',
+    'CurrentUserRestApi.get_me',
+    'Superset.log',
     'DataSetChangeAPI.post_dataset_change',
     'OAuth.issue_access_token',
     'SelectDomainView.list',
@@ -55,6 +78,58 @@ def ensure_domain_selected():
         return redirect(url_for('SelectDomainView.list', next=request.url))
 
 
+def sync_user_domain_role():
+    if is_user_admin() or (
+        request.url_rule
+        and request.url_rule.endpoint in DOMAIN_EXCLUDED_VIEWS
+    ):
+        return
+    if _domain_role_expired():
+        # only sync if another sync not in progress
+        if not _sync_in_progress():
+            return _perform_sync_domain_role()
+
+
+def _domain_role_expired():
+    if not session.get(SESSION_DOMAIN_ROLE_LAST_SYNCED_AT):
+        return True
+
+    time_since_last_sync = datetime_utcnow() - session[SESSION_DOMAIN_ROLE_LAST_SYNCED_AT]
+    return time_since_last_sync >= timedelta(minutes=USER_DOMAIN_ROLE_EXPIRY)
+
+
+def _sync_in_progress():
+    return cache_manager.cache.get(_sync_domain_role_cache_key())
+
+
+def _sync_domain_role_cache_key():
+    return f"{g.user.id}_{g.hq_domain}_sync_domain_role"
+
+
+def _perform_sync_domain_role():
+    cache_key = _sync_domain_role_cache_key()
+
+    # set cache for 30 seconds
+    cache_manager.cache.set(cache_key, True, timeout=30)
+    sync_domain_role_response = _sync_domain_role()
+    cache_manager.cache.delete(cache_key)
+
+    return sync_domain_role_response
+
+def _sync_domain_role():
+    if not DomainSyncUtil(superset.appbuilder.sm).sync_domain_role(g.hq_domain):
+        error_message = (
+            f"Either your permissions for the project '{g.hq_domain}' were revoked or "
+            "your permissions failed to refresh. "
+            "Please select the project space again or login again to resolve. "
+            "If issue persists, please submit a support request."
+        )
+        return current_app.response_class(
+            response=error_message,
+            status=400,
+        )
+
+
 def is_valid_user_domain(hq_domain):
     # Admins have access to all domains
     return is_user_admin() or hq_domain in user_domains()
@@ -71,7 +146,6 @@ def user_domains():
 
 
 def add_domain_links(active_domain, domains):
-    import superset
     for domain in domains:
         superset.appbuilder.menu.add_link(domain, category=active_domain, href=url_for('SelectDomainView.select', hq_domain=domain))
 

hq_superset/migrations/versions/2024-02-24_23-53_56d0467ff6ff_added_oauth_tables.py

@@ -6,9 +6,8 @@
 """
 from typing import Sequence, Union
 
-from alembic import op
 import sqlalchemy as sa
-
+from alembic import op
 
 # revision identifiers, used by Alembic.
 revision: str = '56d0467ff6ff'

hq_superset/models.py

@@ -8,9 +8,13 @@
 from cryptography.fernet import MultiFernet
 from superset import db
 
-from .const import OAUTH2_DATABASE_NAME
-from .exceptions import TableMissing
-from .utils import cast_data_for_table, get_fernet_keys, get_hq_database
+from hq_superset.const import OAUTH2_DATABASE_NAME
+from hq_superset.exceptions import TableMissing
+from hq_superset.utils import (
+    cast_data_for_table,
+    get_fernet_keys,
+    get_hq_database,
+)
 
 
 @dataclass

hq_superset/oauth.py

@@ -6,11 +6,11 @@
 from requests.exceptions import HTTPError
 from superset.security import SupersetSecurityManager
 
-from .exceptions import OAuthSessionExpired
-from .utils import (
+from hq_superset.const import (
     SESSION_OAUTH_RESPONSE_KEY,
     SESSION_USER_DOMAINS_KEY,
 )
+from hq_superset.exceptions import OAuthSessionExpired
 
 logger = logging.getLogger(__name__)
 

hq_superset/oauth2_server.py

@@ -13,7 +13,7 @@
 )
 from authlib.oauth2.rfc6749 import grants
 
-from .models import OAuth2Client, OAuth2Token, db
+from hq_superset.models import OAuth2Client, OAuth2Token, db
 
 
 def save_token(token: dict, request: FlaskOAuth2Request) -> None:

hq_superset/services.py

@@ -13,16 +13,16 @@
 from superset.extensions import cache_manager
 from superset.sql_parse import Table
 
-from .exceptions import HQAPIException
-from .hq_requests import HQRequest
-from .hq_url import (
+from hq_superset.exceptions import HQAPIException
+from hq_superset.hq_requests import HQRequest
+from hq_superset.hq_url import (
     datasource_details,
     datasource_export,
     datasource_subscribe,
     datasource_unsubscribe,
 )
-from .models import OAuth2Client
-from .utils import (
+from hq_superset.models import OAuth2Client
+from hq_superset.utils import (
     convert_to_array,
     generate_secret,
     get_column_dtypes,

hq_superset/tasks.py

@@ -2,9 +2,9 @@
 
 from superset.extensions import celery_app
 
-from .exceptions import TableMissing
-from .models import DataSetChange
-from .services import AsyncImportHelper, refresh_hq_datasource
+from hq_superset.exceptions import TableMissing
+from hq_superset.models import DataSetChange
+from hq_superset.services import AsyncImportHelper, refresh_hq_datasource
 
 
 @celery_app.task(name='refresh_hq_datasource_task')

hq_superset/tests/base_test.py

@@ -2,15 +2,17 @@
 """
 Base TestCase class
 """
-
 import os
 import shutil
 
+import jwt
 from flask_testing import TestCase
 from sqlalchemy.sql import text
 from superset.app import create_app
 
-from hq_superset.utils import DOMAIN_PREFIX, get_hq_database
+from hq_superset.const import DOMAIN_PREFIX
+from hq_superset.tests.utils import OAuthMock
+from hq_superset.utils import get_hq_database
 
 superset_test_home = os.path.join(os.path.dirname(__file__), ".test_superset")
 shutil.rmtree(superset_test_home, ignore_errors=True)
@@ -48,3 +50,33 @@ def tearDown(self):
                     sql = "; ".join(domain_schemas) + ";"
                     connection.execute(text(sql))
         super(HQDBTestCase, self).tearDown()
+
+
+class LoginUserTestMixin(object):
+    """
+    Use this mixin by calling login function with client
+    & then logout once done for clearing the session
+    """
+    def login(self, client):
+        self._setup_user()
+        # bypass oauth-workflow by skipping login and oauth flow
+        with client.session_transaction() as session_:
+            session_["oauth_state"] = "mock_state"
+        state = jwt.encode({}, "mock_state", algorithm="HS256")
+        return client.get(f"/oauth-authorized/commcare?state={state}", follow_redirects=True)
+
+    def _setup_user(self):
+        self.app.appbuilder.add_permissions(update_perms=True)
+        self.app.appbuilder.sm.sync_role_definitions()
+
+        self.oauth_mock = OAuthMock()
+        self.app.appbuilder.sm.oauth_remotes = {"commcare": self.oauth_mock}
+
+        gamma_role = self.app.appbuilder.sm.find_role('Gamma')
+        self.user = self.app.appbuilder.sm.find_user(self.oauth_mock.user_json['username'])
+        if not self.user:
+            self.user = self.app.appbuilder.sm.add_user(**self.oauth_mock.user_json, role=[gamma_role])
+
+    @staticmethod
+    def logout(client):
+        return client.get("/logout/")

hq_superset/tests/config_for_tests.py

@@ -65,3 +65,4 @@
 # CommCare Analytics extensions
 FLASK_APP_MUTATOR = flask_app_mutator
 CUSTOM_SECURITY_MANAGER = oauth.CommCareSecurityManager
+USER_DOMAIN_ROLE_EXPIRY = 60 # minutes

hq_superset/tests/const.py

@@ -108,3 +108,16 @@
   "id": "test1_ucr1",
   "resource_uri": "/a/demo/api/v0.5/ucr_data_source/52a134da12c9b801bd85d2122901b30c/"
 }
+
+TEST_UCR_CSV_V1 = """\
+doc_id,inserted_at,data_visit_date_eaece89e,data_visit_number_33d63739,data_lmp_date_5e24b993,data_visit_comment_fb984fda
+a1, 2021-12-20, 2022-01-19, 100, 2022-02-20, some_text
+a2, 2021-12-22, 2022-02-19, 10, 2022-03-20, some_other_text
+"""
+
+TEST_UCR_CSV_V2 = """\
+doc_id,inserted_at,data_visit_date_eaece89e,data_visit_number_33d63739,data_lmp_date_5e24b993,data_visit_comment_fb984fda
+a1, 2021-12-20, 2022-01-19, 100, 2022-02-20, some_text
+a2, 2021-12-22, 2022-02-19, 10, 2022-03-20, some_other_text
+a3, 2021-11-22, 2022-01-19, 10, 2022-03-20, some_other_text2
+"""

hq_superset/tests/test_hq_domain.py

@@ -2,6 +2,7 @@
 
 from flask import g
 
+from hq_superset.const import SESSION_USER_DOMAINS_KEY
 from hq_superset.hq_domain import (
     DOMAIN_EXCLUDED_VIEWS,
     after_request_hook,
@@ -10,15 +11,13 @@
     is_valid_user_domain,
     user_domains,
 )
+from hq_superset.tests.base_test import HQDBTestCase, SupersetTestCase
 from hq_superset.utils import (
-    SESSION_USER_DOMAINS_KEY,
     DomainSyncUtil,
     get_hq_database,
     get_schema_name_for_domain,
 )
 
-from .base_test import HQDBTestCase, SupersetTestCase
-
 MOCK_DOMAIN_SESSION = {
     SESSION_USER_DOMAINS_KEY:[
         {

hq_superset/tests/test_oauth.py

@@ -3,14 +3,13 @@
 
 from flask import session
 
-from hq_superset.exceptions import OAuthSessionExpired
-from hq_superset.oauth import get_valid_cchq_oauth_token
-from hq_superset.utils import (
+from hq_superset.const import (
     SESSION_OAUTH_RESPONSE_KEY,
     SESSION_USER_DOMAINS_KEY,
 )
-
-from .base_test import SupersetTestCase
+from hq_superset.exceptions import OAuthSessionExpired
+from hq_superset.oauth import get_valid_cchq_oauth_token
+from hq_superset.tests.base_test import SupersetTestCase
 
 
 class MockResponse: