Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates support for CRA 5. #372

Closed
wants to merge 3 commits into from
Closed

Updates support for CRA 5. #372

wants to merge 3 commits into from

Conversation

plpaquin
Copy link

@plpaquin plpaquin commented Jan 3, 2022

No description provided.

@plpaquin
Copy link
Author

plpaquin commented Jan 3, 2022

@patricklafrance Was this ready to go?

@Codex-
Copy link
Contributor

Codex- commented Jan 11, 2022

Tested these changes out with our react-scripts v5 migration and am hitting mismatched snapshots 🤔

  babel: {
    presets: [['@emotion/babel-preset-css-prop', { labelFormat: '[dirname]-[filename]-[local]' }]]
  },

Which may be correct now but not before? It's a little spooky lol:
image

@kitsunekyo
Copy link

kitsunekyo commented Jan 13, 2022

i've created a PR on your fork to add the missing handling for the webpack5 postcss-loader

https://github.com/plpaquin/craco/pull/1

fix: support postcss-loader for webpack5
@plpaquin plpaquin marked this pull request as ready for review January 13, 2022 16:47
@arbaaz
Copy link

arbaaz commented Jan 14, 2022

Any updates on this?

@plpaquin
Copy link
Author

In the meantime, if anyone wants to test drive the changes from this pull request, they may do so using this temporary version here: @plpaquin/craco.

@ShvedDmytro
Copy link

will we have support CRA 5 ever ?

@sahinvardar
Copy link

BTW is there something we can do to help out this PR going through ?
Let me know if I can help somehow.

@Codex-
Copy link
Contributor

Codex- commented Jan 29, 2022

BTW is there something we can do to help out this PR going through ? Let me know if I can help somehow.

The issue for tracking this is: #378

@olivierbeaulieu has kindly published 7.0.0-alpha.0 (huge thanks)

Looks like progress is being made and any issues with the alpha should go there? 🙏

@plpaquin plpaquin closed this Jan 30, 2022
@plpaquin plpaquin deleted the plpaquin/issue-353 branch January 30, 2022 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants