Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicate broadcast fix #1370

Conversation

maheshsattala
Copy link
Contributor

@maheshsattala maheshsattala commented Jul 24, 2024

fixed duplicate broadcast logs in chat history.

Summary by CodeRabbit

  • Bug Fixes
    • Improved logging efficiency by preventing duplicate entries for broadcast messages, enhancing performance and clarity in conversation history.

Copy link

coderabbitai bot commented Jul 24, 2024

Walkthrough

The recent changes enhance the logging mechanism within the broadcast processor by preventing duplicate entries. A new list tracks logged message IDs, ensuring that each message is only recorded once. This improvement streamlines the logging process, optimizes performance, and reduces clutter in conversation history without altering any public interfaces.

Changes

Files Change Summary
kairon/shared/chat/broadcast/processor.py Introduced a mechanism to prevent duplicate logging of broadcast messages by tracking logged message IDs, enhancing logging efficiency and performance.

Poem

In the meadow where bunnies hop,
Logs once echoed, now they stop.
With IDs tracked, we sing with glee,
No more duplicates, just harmony! 🐇✨
A clean log makes our hearts delight,
As we frolic in the moonlit night!


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 94d197e and 001cd04.

Files selected for processing (1)
  • kairon/shared/chat/broadcast/processor.py (2 hunks)
Additional comments not posted (2)
kairon/shared/chat/broadcast/processor.py (2)

167-167: Initialize logged_msg_ids outside the loop.

The initialization of the logged_msg_ids list is correct and ensures that the list is empty at the start of the function.


180-186: Prevent duplicate logging of broadcast messages.

The conditional check ensures that a message ID is only logged if it has not been previously recorded in logged_msg_ids. This prevents duplicate logging and improves the accuracy of the chat logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant