Fix Invalid base64 length when encode base64

[wklaczynski]

When using the base64 encoding function, it is often the case that the digitized string is too short to be divisible by 4. This is because some numbers using charCodeAt are too large and fall outside the range of 64 by substituting none in place of the code. The situation is improved by adding alignment to byte.

util.binary.base64.encode = function(input, maxline) {
  var line = '';
  var output = '';
  var chr1, chr2, chr3;
  var i = 0;
  while(i < input.byteLength) {
    chr1 = input[i++] & 0xff;
    chr2 = input[i++] & 0xff;
    chr3 = input[i++] & 0xff;

util.encode64 = function(input, maxline) {
  // TODO: deprecate: "Deprecated. Use util.binary.base64.encode instead."
  var line = '';
  var output = '';
  var chr1, chr2, chr3;
  var i = 0;
  while(i < input.length) {
    chr1 = input.charCodeAt(i++) & 0xff;
    chr2 = input.charCodeAt(i++) & 0xff;
    chr3 = input.charCodeAt(i++) & 0xff;

[davidlehn]

Can you please add a test case to the test suite that shows the error and that the fix works. Thanks.

[davidlehn]

Also see #932.

[davidlehn]

That last commit title is confusing, did you commit the right files? We're not currently using package-lock.json in this project. Please remove it from the PR history.