Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release workflow for GitHub releases #2189

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

@Goooler
Copy link
Contributor Author

Goooler commented Jul 1, 2024

Some Gradle tasks that were added for printing release notes and performing related actions may now be removed. Please check them.

Copy link
Member

@nedtwigg nedtwigg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, this has been bothering me for a while. I didn't realize it was as easy as gh release create, but actually that makes sense that github actions has that already logged in.

The logic here is pretty complex. I might be misunderstanding, but it looks like we would want prerelease to true for ffurrer2/extract-release-notes? EDIT: I see from your example that it is already tested, so it must be right I guess

But either way, seems like a better approach is just for this task to call gh blah?

Maybe the API should look like this?

spotlessChanglog {
  afterPushExec "gh release create {{tag}} --title plugin-gradle --notes '{{unreleased}}'"
}

@Goooler
Copy link
Contributor Author

Goooler commented Jul 2, 2024

  1. Something like softprops/action-gh-release can do this release as well, I use GH CLI here as GH officially supports it.
  2. ffurrer2/extract-release-notes is for extracting release notes from changelog files, there might be similar mechanisms implemented by other tools but GH, I filed an issue to Support parsing release notes from changelog files cli/cli#9276.
  3. Yeah we can call gh release ... from the Gradle side, but the key point is how to obtain the release notes, this is why I introduce some action steps here.

@Goooler
Copy link
Contributor Author

Goooler commented Jul 2, 2024

I just filed a new issue about the third part to diffplug/spotless-changelog#49.

.github/workflows/deploy.yml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can we create releases from tags?
2 participants