Ensure that network timeout info shows up in the info panel #7155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
TimeoutCursor()function sets up the info panel to display basic information about why the game is lagging.devilutionX/Source/diablo.cpp
Lines 1476 to 1478 in 15e44a1
This text was being overwritten by the logic in
DrawInfoBox()unless the player was highlighting an item or something that would skip that logic. This means the text sometimes shows up and sometimes doesn't. This PR simply adjusts the logic inDrawInfoBox()to detect when the game is lagging and avoid clearing the info text, overwriting it with something else, or using the wrong text color.