Grpc-lwt: fetch status code from response header #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quernd
reviewed
May 4, 2024
lib/grpc-lwt/client.ml
Outdated
| @@ -44,7 +44,7 @@ let call ~service ~rpc ?(scheme = "https") ~handler ~(do_request : do_request) | |||
| match response.status with | |||
| | `OK -> | |||
| let+ status = | |||
| match H2.Headers.get headers "grpc-status" with | |||
| match H2.Headers.get response.headers "grpc-status" with | |||
| | Some _ -> Lwt.return (Grpc.Status.extract_status headers) | |||
There was a problem hiding this comment.
Suggested change
| | Some _ -> Lwt.return (Grpc.Status.extract_status headers) | |
| | Some _ -> Lwt.return (Grpc.Status.extract_status response.headers) |
There was a problem hiding this comment.
This should also extract the status from the response headers, no?
There was a problem hiding this comment.
Thanks, I completely overlooked that second instance of headers. I have made the change in the latest version of the PR.
acerone85
force-pushed
the
acerone85@grpc-lwt-fix-status-response-header
branch
from
cb28ccf to
1e5b0c9
Compare
acerone85
force-pushed
the
acerone85@grpc-lwt-fix-status-response-header
branch
from
1e5b0c9 to
695d451
Compare
quernd
approved these changes
May 5, 2024
|
@tmcgilchrist please merge at your own discretion - I am not familiar with the lwt version myself. |
tmcgilchrist
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In `Grpc_lwt.Client.call, after receiving the response, the function checks for the response status code from the headers of the request. When this is not found, the function waits to receive the trailers from the remote to infer the response status code. If the response does not include any trailer received, the function will hang.
If needed, I can provide a working example where an ocaml grpc client hangs after calling a server implemented in rust/tonic, where the handler of the service returns status code
12: Unimplemented.The client should look for the response status code from the headers of the response (not the request). The change is done in this PR.