Use env where it works #1877
Merged
Use env where it works #1877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Can you observe an effect of No idea regarding |
|
Yes! It actually makes some things a wee bit faster. |
sjakobi
approved these changes
Jun 23, 2020
There was a problem hiding this comment.
Cool!
BTW, if you need more reliable benchmark results, you can also try the --measure-with option:
http://hackage.haskell.org/package/gauge-0.2.5/docs/Gauge-Main-Options.html#t:Config
Feel free to merge yourself or add the merge-me label to let mergify take care of it.
|
This is the bug that inspired |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This use env so that bits of memory are only alive while the appropriate benchmark is being run. This makes the benchmarks more independent from one another; otherwise the allocator/garbage collector interfere across benchmarks.
This doesn't work with
loadPrelude; not quite sure why - perhaps the directory change?