fix(core): Fix regression in parsing json empty string #9108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgraph-bot
added
area/testing
shivaji-dgraph
force-pushed
the
shiva/empty_string
branch
2 times, most recently
from
f055af4
to
dee07a9
Compare
shivaji-dgraph
force-pushed
the
shiva/empty_string
branch
from
dee07a9
to
d52f3a8
Compare
harshil-goel
approved these changes
Jul 5, 2024
harshil-goel
changed the title
ryanfoxtyler
pushed a commit
that referenced
this pull request
Jul 21, 2024
Currently when we parse an empty string, a json empty array is returned. This is a regression. This diff fixes it. We disallow any vector of empty length.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when we parse an empty string, a json empty array is returned. This is a regression. This diff fixes it. We disallow any vector of empty length.