-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add unit testing and using Guzzle #12
base: master
Are you sure you want to change the base?
Conversation
Thank you for PR. What is the benefit to use the Guzzle instead of cURL? |
|
I am +1 on this PR. Ideally you should pass a PSR-7 compatible implementation and use it. As @perter279k said Guzzle is a very good choice and I can add to the list the killer feature: middlewares Interesting middlewares for this project can be
|
@grunjol I have no experience with this. Can you please give an example code, how can be used middleware for cache or retry used? |
Today I had to implement it for a project I am working on, so I rushed it and took @peter279k master (which this PR is based on) and forked the repo. Check it out https://github.com/grunjol/rss-php, I put some examples in the README file including a volatile (memory) cache, you can use any other cache backend (https://github.com/Kevinrob/guzzle-cache-middleware) |
Thanks! |
Any updates on this? |
I don't receive any request changes for while. I still wait for the response :). |
@dg Can you merge this in? |
Change log