Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(signer): Add clone to signer pocket-ic types #173

Merged
merged 1 commit into from
Oct 29, 2024
Merged

chore(signer): Add clone to signer pocket-ic types #173

merged 1 commit into from
Oct 29, 2024

Conversation

bitdivine
Copy link
Member

Motivation

In signer tests, it is sometimes necessary to copy types.

Changes

  • Add Clone to the list of derived traits on signer API types.

Tests

Existing CI should suffice.

@bitdivine bitdivine marked this pull request as ready for review October 29, 2024 15:22
@bitdivine bitdivine enabled auto-merge (squash) October 29, 2024 15:26
@bitdivine bitdivine merged commit cab561a into main Oct 29, 2024
9 checks passed
@bitdivine bitdivine deleted the signer-clone branch October 29, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntonioVentilii-DFINITY AntonioVentilii-DFINITY AntonioVentilii-DFINITY approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bitdivine @AntonioVentilii-DFINITY