Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reduce block ingestion instruction limit from 2B to 1B #294

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

ielashi
Copy link
Collaborator

@ielashi ielashi commented Apr 26, 2024

Reducing the amount of instructions done per round when ingesting blocks to 1B should result in a smoother finalization rate on the subnet.

@ielashi ielashi requested a review from a team as a code owner April 26, 2024 09:42
@ielashi ielashi enabled auto-merge (squash) April 26, 2024 09:45
Copy link

github-actions bot commented Apr 26, 2024

canbench 🏋

No significant performance changes detected ✅

./canbench_results.yml is up to date ✅

~/work/bitcoin-canister/bitcoin-canister/scripts ~/work/bitcoin-canister/bitcoin-canister
~/work/bitcoin-canister/bitcoin-canister

---------------------------------------------------

Benchmark: insert_300_blocks
  total:
    instructions: 561.77 M (-0.00%) (change within noise threshold)
    heap_increase: 6 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: get_metrics
  total:
    instructions: 87.00 M (-0.00%) (change within noise threshold)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: insert_block_headers
  total:
    instructions: 3.90 B (-0.00%) (change within noise threshold)
    heap_increase: 2 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: insert_block_headers_multiple_times
  total:
    instructions: 13.90 B (-0.00%) (change within noise threshold)
    heap_increase: 7 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

@ielashi ielashi disabled auto-merge April 26, 2024 10:21
@ielashi ielashi enabled auto-merge (squash) April 26, 2024 10:26
@@ -400,7 +400,7 @@ mod test {

// Ingest the next block. This time, the performance counter is set so that
// the ingestion is time-sliced.
crate::runtime::set_performance_counter_step(1_000_000_000);
crate::runtime::set_performance_counter_step(100_000_000);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason we decreased the counter step here 10 times, why everywhere else it is halved?

@ielashi ielashi merged commit c554758 into master Apr 26, 2024
25 checks passed
@ielashi ielashi deleted the ielashi/slicing branch April 26, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants