Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix ic-http doc test #287

Merged
merged 1 commit into from
Apr 3, 2024
Merged

fix: fix ic-http doc test #287

merged 1 commit into from
Apr 3, 2024

Conversation

maksymar
Copy link
Contributor

@maksymar maksymar commented Apr 3, 2024

This PR fixes ic-http doc test by explicitly using u8 type.

@maksymar maksymar self-assigned this Apr 3, 2024
Copy link

github-actions bot commented Apr 3, 2024

canbench 🏋

No significant performance changes detected ✅

./canbench_results.yml is up to date ✅

~/work/bitcoin-canister/bitcoin-canister/scripts ~/work/bitcoin-canister/bitcoin-canister
~/work/bitcoin-canister/bitcoin-canister

---------------------------------------------------

Benchmark: insert_300_blocks
  total:
    instructions: 561.77 M (no change)
    heap_increase: 6 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: get_metrics
  total:
    instructions: 87.00 M (no change)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: insert_block_headers
  total:
    instructions: 3.90 B (no change)
    heap_increase: 2 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: insert_block_headers_multiple_times
  total:
    instructions: 13.90 B (no change)
    heap_increase: 7 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

@maksymar maksymar marked this pull request as ready for review April 3, 2024 12:00
@maksymar maksymar requested a review from a team as a code owner April 3, 2024 12:00
@maksymar maksymar requested a review from ielashi April 3, 2024 12:01
@maksymar maksymar merged commit 1efb201 into master Apr 3, 2024
25 checks passed
@maksymar maksymar deleted the maksym/ic-http-test-fix branch April 3, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants