Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update metadata of validation and test-utils crate #285

Merged
merged 12 commits into from
Mar 28, 2024

Conversation

ielashi
Copy link
Collaborator

@ielashi ielashi commented Mar 28, 2024

The IC repo depends on these crates. Rather than depending on specific commits, which has been causing issues with bazel, we'll deploy these crates to crates.io and have them properly versioned. The IC repo will be updated to use these versions as well.

@ielashi ielashi requested a review from a team as a code owner March 28, 2024 10:25
@ielashi ielashi changed the base branch from master to ielashi/fix_ci March 28, 2024 10:25
Copy link

github-actions bot commented Mar 28, 2024

canbench 🏋

No significant performance changes detected ✅

./canbench_results.yml is up to date ✅

~/work/bitcoin-canister/bitcoin-canister/scripts ~/work/bitcoin-canister/bitcoin-canister
~/work/bitcoin-canister/bitcoin-canister

---------------------------------------------------

Benchmark: insert_300_blocks
  total:
    instructions: 561.77 M (no change)
    heap_increase: 6 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: get_metrics
  total:
    instructions: 87.00 M (no change)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: insert_block_headers
  total:
    instructions: 3.90 B (no change)
    heap_increase: 2 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: insert_block_headers_multiple_times
  total:
    instructions: 13.90 B (no change)
    heap_increase: 7 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Base automatically changed from ielashi/fix_ci to master March 28, 2024 12:42
@ielashi ielashi enabled auto-merge (squash) March 28, 2024 12:43
@ielashi ielashi merged commit 8dc7528 into master Mar 28, 2024
25 checks passed
@ielashi ielashi deleted the ielashi/validation_metadata branch March 28, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants