Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken CI on master #284

Merged
merged 8 commits into from
Mar 28, 2024
Merged

fix: broken CI on master #284

merged 8 commits into from
Mar 28, 2024

Conversation

ielashi
Copy link
Collaborator

@ielashi ielashi commented Mar 27, 2024

The way DFX is installed has changed, causing our CI script to fail. This commit updates it to use the official github action to avoid this from happening again in the future.

Copy link

github-actions bot commented Mar 27, 2024

canbench 🏋

No significant performance changes detected ✅

./canbench_results.yml is up to date ✅

~/work/bitcoin-canister/bitcoin-canister/scripts ~/work/bitcoin-canister/bitcoin-canister
~/work/bitcoin-canister/bitcoin-canister

---------------------------------------------------

Benchmark: insert_300_blocks
  total:
    instructions: 561.77 M (no change)
    heap_increase: 6 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: get_metrics
  total:
    instructions: 87.00 M (no change)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: insert_block_headers
  total:
    instructions: 3.90 B (no change)
    heap_increase: 2 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: insert_block_headers_multiple_times
  total:
    instructions: 13.90 B (no change)
    heap_increase: 7 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

@ielashi ielashi changed the title fix: CI fix: broken CI on master Mar 27, 2024
@ielashi ielashi marked this pull request as ready for review March 27, 2024 11:48
@ielashi ielashi requested a review from a team as a code owner March 27, 2024 11:48
@ielashi ielashi merged commit b607277 into master Mar 28, 2024
25 checks passed
@ielashi ielashi deleted the ielashi/fix_ci branch March 28, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants