Skip to content

Commit

Permalink
chore: reduce block ingestion instruction limit from 2B to 1B
Browse files Browse the repository at this point in the history
  • Loading branch information
ielashi committed Apr 26, 2024
1 parent 3a0d299 commit 76c4bc9
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions canister/src/heartbeat.rs
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@ mod test {

// Set a large step for the performance_counter to exceed the instructions limit quickly.
// This value allows ingesting 3 inputs/outputs per round.
runtime::set_performance_counter_step(500_000_000);
runtime::set_performance_counter_step(250_000_000);

// Fetch blocks.
heartbeat().await;
Expand Down Expand Up @@ -508,7 +508,7 @@ mod test {

// Set a large step for the performance_counter to exceed the instructions limit quickly.
// This value allows ingesting 3 transactions inputs/outputs per round.
runtime::set_performance_counter_step(500_000_000);
runtime::set_performance_counter_step(250_000_000);

// Fetch blocks.
heartbeat().await;
Expand Down
2 changes: 1 addition & 1 deletion canister/src/tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -461,7 +461,7 @@ async fn time_slices_large_block_with_multiple_transactions() {

// Set a large step for the performance_counter to exceed the instructions limit quickly.
// This value allows ingesting 2 transactions inputs/outputs per round.
runtime::set_performance_counter_step(750_000_000);
runtime::set_performance_counter_step(375_000_000);

// Fetch blocks.
heartbeat().await;
Expand Down
6 changes: 3 additions & 3 deletions canister/src/utxo_set.rs
Original file line number Diff line number Diff line change
Expand Up @@ -555,9 +555,9 @@ impl PartialEq for UtxoSet {
// Checks that we're not approaching the instructions limit.
fn default_should_time_slice() -> Box<dyn FnMut() -> bool> {
// The threshold at which time slicing kicks in.
// At the time of this writing it is equivalent to 40% of the maximum instructions limit.
// NOTE: We've reduced this limit from 4B to 2B in an effort to keep the FR stable.
const MAX_INSTRUCTIONS_THRESHOLD: u64 = 2_000_000_000;
// At the time of this writing it is equivalent to 20% of the maximum instructions limit.
// NOTE: We've reduced this limit from 4B to 1B in an effort to keep the FR stable.
const MAX_INSTRUCTIONS_THRESHOLD: u64 = 1_000_000_000;

// NOTE: We're using `inc_performance_counter` here to also increment the mock performance
// counter in the unit tests.
Expand Down

0 comments on commit 76c4bc9

Please sign in to comment.