Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

world/viewer.go: Allow for more complex entity animations to be played #940

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

TwistedAsylumMC
Copy link
Member

Continuation from #806 with a few changes. I am still undecided whether this deserves to be its own package or if it's something we can move into the entity package and have entity.NewAnimation(...)

@TwistedAsylumMC TwistedAsylumMC added the feature New feature or request label Nov 18, 2024
Copy link
Member

@Sandertv Sandertv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, no comments other than some suggestions for moving this over to transactions.

server/world/world.go Outdated Show resolved Hide resolved
server/world/world.go Outdated Show resolved Hide resolved
server/world/entity_animation.go Show resolved Hide resolved
@Sandertv Sandertv added this to the v0.10.0 milestone Nov 27, 2024
@Sandertv Sandertv merged commit 02fa0e8 into master Nov 28, 2024
4 checks passed
@Sandertv Sandertv deleted the feature/playentityanimation branch November 28, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants