Implemented vines #578
Open
Implemented vines #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
89 tasks
DaPigGuy
reviewed
Jul 21, 2022
JustTalDevelops
added
the
awaiting response
JustTalDevelops
removed
the
awaiting response
DaPigGuy
requested changes
Jul 24, 2022
| // Vines can't spread upwards unless there is air. | ||
| return | ||
| } | ||
|
|
There was a problem hiding this comment.
According to the wiki, there can not be more than 4 vines in a 9x9x3 area to spread upwards
Comment on lines
+168
to
+179
| } else if vines { | ||
| var changed bool | ||
| for _, f := range cube.HorizontalFaces() { | ||
| if r.Intn(2) == 0 && v.Attachment(f.Direction()) { | ||
| newVines, changed = newVines.SetAttachment(f.Direction(), true), true | ||
| } | ||
| } | ||
| if changed { | ||
| w.SetBlock(selectedPos, newVines, nil) | ||
| } | ||
| return | ||
| } |
There was a problem hiding this comment.
Please check this behavior as it does not match what the wiki says for downwards spread to non-air blocks
JustTalDevelops
added
the
awaiting response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #572.