Remove opt-in feature :(

server/cmd/command.go

@@ -48,7 +48,6 @@ type Command struct {
 	description string
 	usage       string
 	aliases     []string
-	visible     bool
 }
 
 // New returns a new Command using the name and description passed. The Runnable passed must be a
@@ -92,12 +91,6 @@ func New(name, description string, aliases []string, r ...Runnable) Command {
 	return Command{name: name, description: description, aliases: aliases, v: runnableValues, usage: strings.Join(usages, "\n")}
 }
 
-// WithAlwaysVisible sets the visible field of the Command struct to the passed value.
-func (cmd Command) WithAlwaysVisible(alwaysVisible bool) Command {
-	cmd.visible = alwaysVisible
-	return cmd
-}
-
 // Name returns the name of the command. The name is guaranteed to be lowercase and will never have spaces in
 // it. This name is used to call the command, and is shown in the /help list.
 func (cmd Command) Name() string {
@@ -122,11 +115,6 @@ func (cmd Command) Aliases() []string {
 	return cmd.aliases
 }
 
-// AlwaysVisible specifies if a command should still be visible even if Allower returned false
-func (cmd Command) AlwaysVisible() bool {
-	return cmd.visible
-}
-
 // Execute executes the Command as a source with the args passed. The args are parsed assuming they do not
 // start with the command name. Execute will attempt to parse and execute one Runnable at a time. If one of
 // the Runnable was able to parse args correctly, it will be executed and no more Runnables will be attempted

server/session/command.go

@@ -56,7 +56,7 @@ func (s *Session) sendAvailableCommands() map[string]map[int]cmd.Runnable {
 			// Don't add duplicate entries for aliases.
 			continue
 		}
-		if run := c.Runnables(s.c); len(run) > 0 || c.AlwaysVisible() {
+		if run := c.Runnables(s.c); len(run) > 0 {
 			m[alias] = run
 		} else {
 			continue
@@ -203,7 +203,7 @@ func (s *Session) resendCommands(before map[string]map[int]cmd.Runnable) (map[st
 
 	for alias, c := range commands {
 		if c.Name() == alias {
-			if run := c.Runnables(s.c); len(run) > 0 || c.AlwaysVisible() {
+			if run := c.Runnables(s.c); len(run) > 0 {
 				m[alias] = run
 			}
 		}