Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the user to import into a different database than the one specified in the file #1973

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tobiasBora
Copy link
Contributor

Fix #1972 The callback allows a quite flexible solution as I can ask to the user a different name if the database already exists etc…

@tobiasBora tobiasBora mentioned this pull request Apr 29, 2024
@dfahlander
Copy link
Collaborator

Could we use a simpler approach and just allow an optional name property? I suppose letting the name depend on the other info from the file is less common use case but when that is needed, one could use peakImportFile() to get that information beforehand.

@tobiasBora
Copy link
Contributor Author

tobiasBora commented Jun 13, 2024

Sorry, I missed your message. I wasn't aware of peakImportFile, it seems indeed to be good enough for my need if an optional name is provided. I'll try to see if it works and submit a new pr if yes. Thanks!

@tobiasBora tobiasBora force-pushed the allow_changing_name_during_import branch 2 times, most recently from 852e0ff to a09272a Compare June 14, 2024 08:11
@tobiasBora tobiasBora force-pushed the allow_changing_name_during_import branch from a09272a to baea429 Compare June 14, 2024 08:15
@tobiasBora
Copy link
Contributor Author

tobiasBora commented Jun 14, 2024

Ok, this one is tested (and fixed) now that I fixed my issue with #1995 (comment) Should be good to merge.

@tobiasBora
Copy link
Contributor Author

Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import a database with a different name
2 participants