Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove docker args and override docker args from save ci pipeline payload conditionally #1877

Open
wants to merge 2 commits into
base: hotfix-v0.12.0
Choose a base branch
from

Conversation

eshankvaish
Copy link
Contributor

@eshankvaish eshankvaish commented Jul 4, 2024

Description

  • fix: remove docker args and override docker args from save ci pipeline payload conditionally

Fixes devtron-labs/devtron#5404

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@eshankvaish eshankvaish marked this pull request as ready for review July 4, 2024 12:33
@eshankvaish eshankvaish self-assigned this Jul 4, 2024
src/components/ciPipeline/utils.ts Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Jul 5, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants