feat: Git optional in CI job pipeline #1505
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR:Issue-verification-failed
mukultayal135
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
Coverage report❌ An unexpected error occurred. For more details, check console
Test suite run failedFailed tests: 17/141. Failed suites: 9/41.Report generated by 🧪jest coverage report action from 810aefa |
| @@ -20,6 +21,7 @@ export interface BuildDetails { | |||
| tagsEditable: boolean | |||
| hideImageTaggingHardDelete: boolean | |||
| fetchIdData: FetchIdDataStatus | |||
| pipeline:CIPipeline | |||
There was a problem hiding this comment.
Please format this line
| @@ -443,7 +440,8 @@ function ciPipelineToNode(ciPipeline: CiPipeline, dimensions: WorkflowDimensions | |||
| isRegex: ciMaterial?.isRegex, | |||
| primaryBranchAfterRegex: ciMaterial?.source?.value, | |||
| cipipelineId: ciMaterial?.id, | |||
| isJobCI: ciPipeline?.pipelineType === CIPipelineBuildType.CI_JOB | |||
| isJobCI: ciPipeline?.pipelineType === CIPipelineBuildType.CI_JOB, | |||
There was a problem hiding this comment.
We can remove the optional check
| if (ci) { | ||
| return _nodes.map((node: NodeAttr) => { | ||
| if (node.type == WorkflowNodeType.GIT) { | ||
| return this.renderSourceNode(node, ci) | ||
| return ((node.isJobCI && node.isGitRequired) || !node.isJobCI) && this.renderSourceNode(node, ci) |
There was a problem hiding this comment.
We can write it as return (!node.isJobCI || node.isGitRequired) &&
|
|
||
| renderNodes() { | ||
| const ci = this.props.nodes.find((node) => node.type == WorkflowNodeType.CI) | ||
| const webhook = this.props.nodes.find((node) => node.type == WorkflowNodeType.WEBHOOK) | ||
| const _nodesData = this.getNodesData(ci?.id || webhook?.id || '') | ||
| const _nodes = _nodesData.nodes | ||
|
|
||
| const _nodes =this.getPositionedNodes( JSON.parse(JSON.stringify(_nodesData.nodes))) |
There was a problem hiding this comment.
Format this line. Why are we doing the stringify and parse here?
| handleOnBlur={handleOnBlur} | ||
| /> | ||
| {isJobCI && renderGitRepoToggle()} | ||
| {((isJobCI && isGitRequired) || !isJobCI) && ( |
There was a problem hiding this comment.
we can write it as {(!isJobCI || isGitRequired) && (
| <div className="w-32 h-20"> | ||
| <Toggle | ||
| selected={isGitRequired} | ||
| onSelect={() => { |
There was a problem hiding this comment.
Please extract this method out.
| @@ -577,6 +584,8 @@ export default function CIPipeline({ | |||
| false, | |||
| formData.webhookConditionList, | |||
| formData.ciPipelineSourceTypeOptions, | |||
|
|
|||
There was a problem hiding this comment.
Please remove this unnecessary space
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This makes cloning and displaying git material based on user choice
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: