-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#888: fixed graalvm gu #890
base: main
Are you sure you want to change the base?
#888: fixed graalvm gu #890
Conversation
added check for graalvm community edition 21 to prevent usage of missing gu command
Pull Request Test Coverage Report for Build 12314210610Details
💛 - Coveralls |
I installed the
Is that error still in the scope of this issue? I can confirm that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jan-vcapgemini thanks for your PR and work to fix #888.
IMHO this current implementation is making it worse not better.
Please check my review comment.
cli/src/main/java/com/devonfw/tools/ide/tool/graalvm/GraalVm.java
Outdated
Show resolved
Hide resolved
replaced check for for graalvm version with check for existing gu command
…-vcapgemini/IDEasy into fix/888-graalvm-gu-installer
changed graalvm from PluginBasedCommandlet to LocalToolCommandlet removed intallplugin implementations adjusted changelog
Fixes: #888
Implements: