Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#888: fixed graalvm gu #890

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

jan-vcapgemini
Copy link
Contributor

@jan-vcapgemini jan-vcapgemini commented Dec 11, 2024

Fixes: #888

Implements:

  • changed graalvm from PluginBasedCommandlet to LocalToolCommandlet
  • removed installplugin implementations
  • adjusted changelog

added check for graalvm community edition 21 to prevent usage of missing gu command
@jan-vcapgemini jan-vcapgemini self-assigned this Dec 11, 2024
@jan-vcapgemini jan-vcapgemini added bugfix graalvm GraalVM, native-image, truffle, etc. native-image GraalVM native image of IDEasy CLI (e.g. for bugs that only happen in binary of CLI) labels Dec 11, 2024
@coveralls
Copy link
Collaborator

coveralls commented Dec 11, 2024

Pull Request Test Coverage Report for Build 12314210610

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 67.459%

Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/cli/CliProcessException.java 2 0.0%
Totals Coverage Status
Change from base Build 12302719390: 0.03%
Covered Lines: 6653
Relevant Lines: 9521

💛 - Coveralls

@alfeilex alfeilex self-requested a review December 11, 2024 15:01
@alfeilex
Copy link
Member

I installed the community edition with version 17.0.9 and I got this error after the installation was completed:

Start: Install plugin native-image
Downloading: Component catalog from www.graalvm.org
Processing Component: Native Image
Component Native Image (org.graalvm.native-image) is already installed.
Step 'Install plugin native-image' ended with failure.
Successfully installed graalvm in version 17.0.9 replacing previous version 20.3.6
  Step 'Install plugin native-image' failed: unexpected error
1 step(s) failed out of 3 steps.

Is that error still in the scope of this issue? I can confirm that gu.cmd is inside the bin folder.

Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jan-vcapgemini thanks for your PR and work to fix #888.
IMHO this current implementation is making it worse not better.
Please check my review comment.

changed graalvm from PluginBasedCommandlet to LocalToolCommandlet
removed intallplugin implementations
adjusted changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix graalvm GraalVM, native-image, truffle, etc. native-image GraalVM native image of IDEasy CLI (e.g. for bugs that only happen in binary of CLI)
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

latest graalvm is not working
4 participants