Some keys are being excluded during order
#239
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test to illustrate the problem but does not (yet) provide a fix.
Note that the
expectObject
function in__tests__/order.test.ts
was not failing due to the expected object having keys in the wrong order. The first commit here fixes that.The issue here appears to be that the key I was testing with contained a
.
, which is also the separator being used. This highlights an issue with the way the order-map is constructed. If any key ever contains the separator, then that key is not going to be included in the final object. Perhaps the solution here is to structure the order-map like an actual object, thereby alleviating the need for a separator: