Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docker-in-docker]-docker_compose-fallback-github api #914

Conversation

gauravsaini04
Copy link
Contributor

Feature name:

  • Docker-In-Docker

Description:

This PR introduces the following functionality:

  • When the latest tag for docker-compose doesn't have a source binary released yet, then it will continue installing the previous working version for which a source binary will be available using these 2 methods:
    • Using github api if rate limit hasn't expired
    • Using get_prev_version_from_git_tags function which is written locally to fetch previous git tags

Changelog:

  • Updated install.sh
  • Updated tests to validate that when a dummy docker-compose version is tried to be downloaded with curl command thus representing trying to access a source binary which is not deployed yet, then will pick up the binary for the tag which will eventually work successfully from either of the two methods mentioned above.

Checklist:

  • Checked that applied changes work as expected

src/docker-in-docker/install.sh Show resolved Hide resolved
src/docker-in-docker/install.sh Outdated Show resolved Hide resolved
src/docker-in-docker/install.sh Outdated Show resolved Hide resolved
src/docker-in-docker/install.sh Outdated Show resolved Hide resolved
src/docker-in-docker/install.sh Outdated Show resolved Hide resolved
src/docker-in-docker/install.sh Outdated Show resolved Hide resolved
src/docker-in-docker/install.sh Outdated Show resolved Hide resolved
src/docker-in-docker/install.sh Outdated Show resolved Hide resolved
src/docker-in-docker/install.sh Outdated Show resolved Hide resolved
src/docker-in-docker/install.sh Outdated Show resolved Hide resolved
src/docker-in-docker/install.sh Outdated Show resolved Hide resolved
src/docker-in-docker/install.sh Outdated Show resolved Hide resolved
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, left some minor comments.

src/docker-in-docker/install.sh Outdated Show resolved Hide resolved
src/docker-in-docker/install.sh Outdated Show resolved Hide resolved
src/docker-in-docker/install.sh Outdated Show resolved Hide resolved
src/docker-in-docker/install.sh Outdated Show resolved Hide resolved
src/docker-in-docker/install.sh Outdated Show resolved Hide resolved
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks wonderful! Thank you so much.

@samruddhikhandale samruddhikhandale merged commit 0100f66 into devcontainers:main Mar 26, 2024
111 checks passed
@gauravsaini04 gauravsaini04 deleted the docker-in-docker_docker-compose_github_api_fallback branch March 27, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants