Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop-lite] - VNC_RESOLUTION unreadable fix - issue #945 fix #1024

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

gauravsaini04
Copy link
Contributor

Feature name:

  • Desktop-lite

Description:

This PR introduces the following functionality :

Changelog:

  • Updated install.sh
  • Added a single quotes wrapper around EOF so as to disable variable expansion during build time, and such that the variable's values can be read when they are needed i.e. during runtime of container.

Checklist:

  • Checked that applied changes work as expected

src/desktop-lite/install.sh Show resolved Hide resolved
src/desktop-lite/install.sh Show resolved Hide resolved
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! ⚡

@samruddhikhandale
Copy link
Member

@gauravsaini04 Can you look into test failures?

@gauravsaini04
Copy link
Contributor Author

@gauravsaini04 Can you look into test failures?

Hi @samruddhikhandale ,
have tested locally with a couple of these scenarios and they seem to be passing the log-exists test there in the codespace

@@ -293,7 +293,7 @@ echo -e "\nSuccess!\n"
EOF

# Container ENTRYPOINT script
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are the tests passing locally?

From https://github.com/devcontainers/features/actions/runs/9719274381/job/27190519697?pr=1024#step:4:3497

It looks like these PR changes are failing the init script run. Can you investigate here?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[desktop-lite] Entrypoint script does not use VNC_RESOLUTION defined by containerEnv
2 participants