-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Desktop-lite] - VNC_RESOLUTION unreadable fix - issue #945 fix #1024
base: main
Are you sure you want to change the base?
[Desktop-lite] - VNC_RESOLUTION unreadable fix - issue #945 fix #1024
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! ⚡
@gauravsaini04 Can you look into test failures? |
Hi @samruddhikhandale , |
@@ -293,7 +293,7 @@ echo -e "\nSuccess!\n" | |||
EOF | |||
|
|||
# Container ENTRYPOINT script |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How are the tests passing locally?
It looks like these PR changes are failing the init script run. Can you investigate here?
Feature name:
Description:
This PR introduces the following functionality :
containerEnv
as a configured option, appearing to be available as an Environment variable during build time, but it can only be read at runtime of container.Changelog:
install.sh
Checklist: